Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Github] Update Logs Private Repository Sync Errors #2816

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

parth-elastic
Copy link
Contributor

@parth-elastic parth-elastic commented Sep 11, 2024

Related to #2636

Included rate limit related information in debug logs

Checklists

Pre-Review Checklist

  • this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check config.yml.example)
  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)
  • Considered corresponding documentation changes
  • Contributed any configuration settings changes to the configuration reference
  • if you added or changed Rich Configurable Fields for a Native Connector, you made a corresponding PR in Kibana

Changes Requiring Extra Attention

  • Security-related changes (encryption, TLS, SSRF, etc)
  • New external service dependencies added.

Related Pull Requests

Release Note

Copy link
Member

@artem-shelkovnikov artem-shelkovnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parth-elastic do you think these logs will be sufficient to investigate the problem?

I'd try to use this branch with the problem that user is having and see if you can debug it. If not, logs should be adjusted.

@parth-elastic
Copy link
Contributor Author

@parth-elastic do you think these logs will be sufficient to investigate the problem?

Yes, we tried to cover all the pieces of information required to debug this issue. Since the issue was regarding the rate limit, we've already covered the exceptions and logs related to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants