[s3] Allow S3-compatible endpoints, expose more options #2759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
There was a problem hiding this comment.
Thanks for the contribution!
Could you add some unit tests to cover the new configurations to the test file?
I think some good tests would be:
- ensuring
self.s3_endpoint_urlis assigned the right value in all circumstances - ensuring
self.configinitializes for all the options for new configss3_addressing_style,aws_use_fips_endpoint, andaws_use_dualstack_endpoint.
| "aws_use_dualstack_endpoint": { | ||
| "display": "toggle", | ||
| "label": "Use Dualstack Endpoints", | ||
| "order": 7, |
There was a problem hiding this comment.
Can you go through the order values for the configurations after this and update them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2758
This change exposes many more configuration options of boto3 to the user. This has the primary intent of allowing S3-Compatible services to be used, but I also carried-through FIP and Dualstack endpoint selection.
Checklists
Pre-Review Checklist
config.yml.example)v7.13.2,v7.14.0,v8.0.0)Release Note
The S3 Connector now exposes options to support S3-Compatible object storage providers.