Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental warning from journald input. #42107

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Dec 18, 2024

Mark the journald input as GA now that it is used as part of the system module and Elastic Agent system integration to collect system logs on Linux distributions that do not enable syslog by default.

@cmacknz cmacknz added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Dec 18, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 18, 2024
@cmacknz cmacknz requested a review from flexitrev December 18, 2024 15:23
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 18, 2024
@cmacknz cmacknz requested a review from belimawr December 18, 2024 15:23
@cmacknz cmacknz self-assigned this Dec 18, 2024
@cmacknz cmacknz added backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify labels Dec 18, 2024
Copy link
Contributor

mergify bot commented Dec 18, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @cmacknz? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Dec 18, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

Copy link
Contributor

@belimawr belimawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need to update the "stability" of the input:

Stability: feature.Experimental,

That forces some deprecation logs. I believe that's the only place.

@cmacknz cmacknz requested a review from a team as a code owner December 18, 2024 15:35
@cmacknz cmacknz requested a review from mauri870 December 18, 2024 15:35
@cmacknz
Copy link
Member Author

cmacknz commented Dec 18, 2024

Thanks for catching that, updated.

@cmacknz cmacknz removed the backport-8.17 Automated backport with mergify label Dec 18, 2024
@cmacknz
Copy link
Member Author

cmacknz commented Dec 18, 2024

Removing backport to 8.17 until elastic/integrations#9690 is addressed.

Copy link

@flexitrev flexitrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants