Skip to content

Commit

Permalink
Send a 404 status code for 404 page (was 200)
Browse files Browse the repository at this point in the history
  • Loading branch information
NicolasCARPi committed Jul 27, 2023
1 parent e97ca1d commit e628b95
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# Container image version
# Note: the version here is from `ELABIMG_VERSION` present in Dockerfile, not the tagged one

# 4.5.1

* Send a 404 status code for 404 page (was 200)

# 4.5.0

* Update to alpine:3.18
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ RUN abuild-keygen -n -a && abuild && find /home/builder/packages -type f -name '
FROM alpine:3.18

# this is versioning for the container image
ENV ELABIMG_VERSION=4.5.0
ENV ELABIMG_VERSION=4.5.1

# the target elabftw version is passed with --build-arg
# it is a mandatory ARG
Expand Down
2 changes: 1 addition & 1 deletion src/nginx/common.conf
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ error_page 400 /error-pages/400.html;
error_page 401 /error-pages/401.html;
error_page 402 /error-pages/402.html;
error_page 403 /error-pages/403.html;
error_page 404 = /error-pages/404.html;
error_page 404 =404 /error-pages/404.html;
error_page 500 /error-pages/500.html;
error_page 501 /error-pages/501.html;
error_page 502 /error-pages/502.html;
Expand Down

0 comments on commit e628b95

Please sign in to comment.