fix issue with urllib3 import

elabftw · Dec 9, 2022 · f4dc5c6 · f4dc5c6
1 parent 0c0393a
commit f4dc5c6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -65,6 +65,14 @@ Use `verify=False` in the Manager initialization to disable TLS certificate veri
 
 ## Dev stuff
 
+### Install dependencies
+
+`pipenv sync -d`
+
+### Run mypy
+
+`pipenv run python -m mypy elabapy`
+
 ### Create new release
 
 * Update version in `setup.py` and `elabapy/__init__.py`

diff --git a/elabapy/baseapi.py b/elabapy/baseapi.py
@@ -6,6 +6,7 @@
 from urllib.parse import urljoin
 
 import requests
+import urllib3
 
 
 class Error(Exception):
@@ -55,7 +56,7 @@ def send_req(
         """ Send the request to the api endpoint. """
         # don't show warnings if we chose to disable certificate verification
         if self.verify == False:
-            requests.packages.urllib3.disable_warnings()
+            urllib3.disable_warnings()
 
         # build url
         url = urljoin(self.endpoint, url)