Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nuked-OPLL sound core to upstream #535

Closed
wants to merge 1 commit into from

Conversation

crashGG
Copy link
Contributor

@crashGG crashGG commented Dec 10, 2023

Update Nuked-OPLL sound core to latest 1.02 upstream

Update Nuked-OPLL sound core to latest 1.02 upstream
@ekeeke
Copy link
Owner

ekeeke commented Dec 10, 2023

Sorry but I can't merge GPL code with non-commercial code, it needs to be licensed under LGPL like latest versions of Nuked OPN2 core or dual-licensed for use in this emulator with the same non-commercial license, as Nuked did with initial version (see dd61657 )

@crashGG
Copy link
Contributor Author

crashGG commented Dec 10, 2023

I don’t know how to modify the license . 1.0-1.02 has made a lot of upgrades and fixes. after compiled it runs fine.

@ekeeke
Copy link
Owner

ekeeke commented Dec 10, 2023

Only copyright owner(s) can change the license.

From what I can tell, the only important change is that commit, which apparently fixes some edge case on channels 8 & 9 (and might not be noticeable in any Master System games with FM support):
nukeykt/Nuked-OPLL@1269cf5

The rest is addition of support for different kind of OPLL chips which is not applicable to this emulator as we only use YM2413 chip support for Master System and minor code refactoring without any functional impact.

@ekeeke
Copy link
Owner

ekeeke commented Dec 10, 2023

Closing this for aforementionned reasons. I will rather backport the latest commit from nuked (other commits having no functional impact for Master System emulation), there is already an user request fo this (see issue #532)

@ekeeke ekeeke closed this Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants