Merging the latest updates from develop #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-api-script Creation of script to check upcoming maintenance on nodes
…ugin-type Fix: variable takes structured data when set
…x-distance Add documentation how to use max_hops plugin
Updated testing procedure to mock out subprocess calls which may not always be available and are slow
…_filestore Add Zonal with lower capacity band support for filestore instance
```sh
=== RUN Test
2023/11/21 21:21:28 Oopsy
FAIL hpc-toolkit/pkg/config 0.058s
```
```sh
=== RUN Test
----------------------------------------------------------------------
FAIL: /usr/local/google/home/orlov/wp/hpc-toolkit/pkg/config/config_test.go:1069: MySuite.TestFatal
/usr/local/google/home/orlov/wp/hpc-toolkit/pkg/config/config_test.go:1070:
c.Fatal("Oopsy")
... Error: Oopsy
OOPS: 38 passed, 1 FAILED
```
Reduce usage of `log.Fatal` in tests, use `c.Fatal` instead
…pc-deploy-output Implement Custom Logging
* Stop using `TestMain`, see `lib/google-golang/src/testing/testing.go` : ```go // TestMain is a low-level primitive and should not be necessary for casual // testing needs, where ordinary test functions suffice. ``` * Use `c.Fatal` instead of `log.Fatal`, see GoogleCloudPlatform#1985 for motivation; * Reduce usage of bloated `get*DeploymentConfigForTest` methods; * Split setup-free tests into separate `zeroSuite`.
Refactor `pkg/config` tests
* Stop using `TestMain`, see `lib/google-golang/src/testing/testing.go` : ```go // TestMain is a low-level primitive and should not be necessary for casual // testing needs, where ordinary test functions suffice. ``` * Use `c.Fatal` instead of `log.Fatal`, see GoogleCloudPlatform#1985 for motivation;
Refactor `pkg/modulewriter` tests
Remove usage of `log.Fatal` from non-tests files
* Stop using `TestMain`, see `lib/google-golang/src/testing/testing.go` : ```go // TestMain is a low-level primitive and should not be necessary for casual // testing needs, where ordinary test functions suffice. ``` * Use `c.Fatal` instead of `log.Fatal`, see GoogleCloudPlatform#1985 for motivation;
…ique-bucket-name Front End Deployment Unique Bucket Name
…e-api-testing Initial testing scripts with new folder for unittests
Refactor `pkg/deploymentio` tests
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.14.0 to 0.15.0. - [Commits](golang/sys@v0.14.0...v0.15.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…main Merge v1.26.0 into development branch
…dependabot/go_modules/develop/golang.org/x/sys-0.15.0 Bump golang.org/x/sys from 0.14.0 to 0.15.0
Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.151.0 to 0.152.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.151.0...v0.152.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…dependabot/go_modules/develop/google.golang.org/api-0.152.0 Bump google.golang.org/api from 0.151.0 to 0.152.0
Bumps [github.com/spf13/afero](https://github.com/spf13/afero) from 1.10.0 to 1.11.0. - [Release notes](https://github.com/spf13/afero/releases) - [Commits](spf13/afero@v1.10.0...v1.11.0) --- updated-dependencies: - dependency-name: github.com/spf13/afero dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…dependabot/go_modules/develop/github.com/spf13/afero-1.11.0 Bump github.com/spf13/afero from 1.10.0 to 1.11.0
Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.10.0 to 5.10.1. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](go-git/go-git@v5.10.0...v5.10.1) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…dependabot/go_modules/develop/github.com/go-git/go-git/v5-5.10.1 Bump github.com/go-git/go-git/v5 from 5.10.0 to 5.10.1
…dependabot/pip/community/front-end/ofe/cryptography-41.0.6 Bump cryptography from 41.0.4 to 41.0.6 in /community/front-end/ofe
Legacy metadata to be removed, added comment.
…s_test Don't test metadata services against legacy ones.
…er_access Document permissions around manual usage of Spack installation
…d-image-examples Adding snippet of commonly used images to make it easy to modify a blueprint
Use older release until we address the code changes required by terraform-linters/tflint-ruleset-terraform#133
…e-api-slurm Slurm flag for maintenance API script
…ocal_ssd_warning Eliminate local SSD warning
Exclude `pkg/*` from `packer-readme` hook.
Disable `go-critic` hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.