Develop #1
Merged
Develop #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated testing procedure to mock out subprocess calls which may not always be available and are slow
* Stop using `TestMain`, see `lib/google-golang/src/testing/testing.go` : ```go // TestMain is a low-level primitive and should not be necessary for casual // testing needs, where ordinary test functions suffice. ``` * Use `c.Fatal` instead of `log.Fatal`, see GoogleCloudPlatform#1985 for motivation;
…ique-bucket-name Front End Deployment Unique Bucket Name
…e-api-testing Initial testing scripts with new folder for unittests
Refactor `pkg/deploymentio` tests
…-version-fix Front End go Version Updated
* Add `addlicense` pre-commit hook; * Remove explicit invokation of it.
Add `addlicense` pre-commit hook
* Add rudimentary codespell config
* Add pre-commit definition for codespell
* ot -> it typo fix
* Some more skips for codespell
* [DATALAD RUNCMD] Do interactive fixing of some ambigous typos
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w -i 3 -C 2 ./community/front-end/ofe/script/service_account.sh ./community/front-end/ofe/website/ghpcfe/models.py ./community/front-end/ofe/website/ghpcfe/models.py ./community/modules/scripts/htcondor-install/files/autoscaler.py ./community/modules/scripts/ramble-setup/README.md ./docs/videos/healthcare-and-life-sciences/README.md ./examples/README.md ./tools/validate_configs/test_configs/README.md",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
* 1 more typo fixed manually
* Skip (S)hortcuts, more words and files
* [DATALAD RUNCMD] run codespell throughout fixing typo automagically
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
* Duplicate ignore of requirements.txt and js in pre-commit config
until codespell-project/codespell#3196 is addressed
ek-nag
pushed a commit
that referenced
this pull request
Dec 8, 2023
) * Augment expression parsing error with position; * Remove `YAML parsing error: ` prefix. ```yaml vars: project_id: $(6 + 4) # Case #1 hello: ((world+)) # Case #2 ``` ```sh YAML parsing error: only traversal expressions are supported, got "6 + 4" YAML parsing error: :0,6-6: Missing expression; Expected the start of an expression, but found the end of the file. Case #1 Error: only traversal expressions are supported, got "6 + 4" 2: project_id: $(6 + 4) Case #2 Error: :0,6-6: Missing expression; Expected the start of an expression, but found the end of the file. 2: hello: ((world+)) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.