Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick proof-of-concept that strips unnecessary deserialization calls #3138

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrisdennis
Copy link
Member

This is a draft PR of a proof-of-concept that eliminates value deserialization from the removeAll call (and maybe some other things). There are two things that make this only a PoC:

  1. The code is ugly and could do with a bunch of cleanup/rationalization.
  2. I made no attempt to confirm that any "moved" deserialization happens safely when deserializing data pulled from offheap/disk. If we delay these deserializations too much then we may pull them outside of the relevant lock scope without taking defensive copies of the data. This could (or more likely would) lead to corruption under heavy multi-threaded access that may not be detected by the tests.

Before this is merged someone needs to go over this code to assess its safety on these dimensions (and cleanup up the general dogs dinner I left behind during my hacking).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant