Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/top GitHub repos #2

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

iahmedgamal
Copy link

@iahmedgamal iahmedgamal commented Jun 28, 2024

πŸ“– Description

I created a new endpoint repos that retrieve top GitHub repos made by Egyptians community

πŸ™‹β€β™‚οΈ Reason For Change

egytech-fyi/egytech-fyi#38

πŸ”„ Change Type

  • New feature (non-breaking change which adds functionality)

πŸ“· Screenshots

image
image_

GITHUB_TOKEN should be added to Wrangler dashboard

image

Please add the GITHUB_TOKEN environment variable to the Wrangler dashboard.

πŸ§ͺ How Has This Been Tested?

I tested that locally as it's shown in the screenshots

🚧 Affected Parts

A new route added.

πŸ“‹ Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@iahmedgamal iahmedgamal marked this pull request as ready for review June 29, 2024 14:44
@iahmedgamal
Copy link
Author

@mahsayedsalem can you have a look please for this PR?

@iahmedgamal
Copy link
Author

Hi @mahsayedsalem,

Just a friendly reminder about this PR. I'd appreciate it if you could take a look at your earliest convenience.
I'm also open to discussing any feedback or changes needed.

Regarding the environment variable for the Wrangler dashboard, I've created an issue for it here: #4
Looking forward to your thoughts on this.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant