embeds #246
Open
embeds #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge and reward |
|
@egoist wouldn't mind just the bounty, pr review whenever you feel like it. Its been half a year. |
|
Actually we only need to use |
|
Updated, please reward money at very long last. |
|
I can't at all tell whats up with the circleci, as it loads a loader with null>null>null for the workflow. I'll go fix another PR to see if youll deign to reward me with that one. |
|
So the circleCI is giving crap during linting that has nothing to do with my code, and doesn't even show up on local machine. |
|
? |
1 similar comment
|
? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #205
I added this into core plugins, and made a separate page in guides for docs.
It doesn't parse titles into sidebar since you'd have to sort out the order in which they should come, which the documentation will note as much. The controls for video/audio is a boolean attribute therefore it can't be overridden with additional attributes like controls='false', and it is set on by default.