-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix putlog timestamp: localtime() -> localtime_r() #1441
Open
michaelortmann
wants to merge
11
commits into
eggheads:develop
Choose a base branch
from
michaelortmann:localtime_r
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelortmann
changed the title
Fix putlog timestamp: localtime() -> localtime_r()
(WIP) Fix putlog timestamp: localtime() -> localtime_r()
Mar 14, 2023
michaelortmann
changed the title
(WIP) Fix putlog timestamp: localtime() -> localtime_r()
Fix putlog timestamp: localtime() -> localtime_r()
Mar 14, 2023
michaelortmann
pushed a commit
to michaelortmann/eggdrop
that referenced
this pull request
Nov 21, 2023
…e of eggheads#1441 and eggheads#1087 for better logging during debug session
michaelortmann
pushed a commit
to michaelortmann/eggdrop
that referenced
this pull request
Nov 21, 2023
…e of eggheads#1441 and eggheads#1087 for better logging during debug session
Closed
Merge done to trigger new CI run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: Arno
Patch by: michaelortmann
Fixes:
One-line summary:
Fix putlog timestamp: localtime() -> localtime_r()
Additional description (if needed):
No, eggdrop didnt invent the time machine, it just suffered from thread-unsafe localtime():
[21:55:36] Writing user file...
[21:55:35] Writing channel file...
This bug was introduced in 2019 by my very self:
5b395f2
Also this patch replaces ctime() with ctime_r()
Test cases demonstrating functionality (if applicable):