Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/kiama lsp #753

Merged
merged 6 commits into from
Dec 21, 2024
Merged

Update/kiama lsp #753

merged 6 commits into from
Dec 21, 2024
+15 −30

Conversation

b-studios
Copy link
Collaborator

Update kiama to support LSP notebooks

@b-studios
Copy link
Collaborator Author

It would be great if one other person (maybe @dvdvgt or @phischu ?) could try out whether this breaks their vscode LSP integration.

It "should" just work ;)

  • check out this branch
  • sbt install
  • Restart vscode or extension host
  • see whether LSP still works (hover over stuff etc.)

@dvdvgt
Copy link
Collaborator

dvdvgt commented Dec 20, 2024 •
edited
Loading

I tested the following features:

  • Go to definition
  • Go to type definition
  • Hover over definitions for querying their (inferred) type
  • Go to references
  • Inlay run main button
  • Show IR

All seems to be well and functions as expected.

@b-studios
Copy link
Collaborator Author

Thanks @dvdvgt !

@b-studios b-studios merged commit d705404 into master Dec 21, 2024
2 checks passed
@b-studios b-studios deleted the update/kiama-lsp branch December 21, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdvgt dvdvgt dvdvgt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b-studios @dvdvgt