Uncomment rewrite #725
Merged
Uncomment rewrite #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiribenes
merged commit 1fb2e80
into
feature/stdlib/treemap-treeset
1 of 2 checks passed
jiribenes
pushed a commit
that referenced
this pull request
Dec 9, 2024
As discussed in #561 (comment)
jiribenes
added a commit
that referenced
this pull request
Dec 9, 2024
As discussed in #561 (comment), there's a missing rewrite. This fix is necessary for the `map` and `set` examples, as well as some of my AoC solutions using them, so I'd like to upstream it, if possible. Co-authored-by: Marvin <[email protected]>
jiribenes
added a commit
that referenced
this pull request
Dec 12, 2024
jiribenes
added a commit
that referenced
this pull request
Dec 12, 2024
Reverts #730 as it seems like an incorrect fix, judging both by the Effekt Working Group meeting, and the graphs after merging it:  
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #561 (comment)