Mutable dynamic arrays, heaps, and simple union find data structures #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiribenes
reviewed
Sep 10, 2024
Comment on lines
9
to
16
| // These numbers should be optimized based on benchmarking | ||
| // According to https://en.wikipedia.org/wiki/Dynamic_array most use 1.5 or 2 | ||
| // | ||
| // Factor by which to grow the capacity when it becomes too small | ||
| val growFactor = 1.5 | ||
| // shrink array when size / capacity falls below this threshold | ||
| // should be < 1/growFactor | ||
| val shrinkThreshold = 0.4 |
There was a problem hiding this comment.
Note that this requires #496 in order to work on LLVM.
There was a problem hiding this comment.
Yes, I know 😢
jiribenes
force-pushed
the
master
branch
3 times, most recently
from
ee9d209 to
58c8510
Compare
|
What happened to this PR, it looks really cool! :) |
|
@b-studios Mostly I didn't get around to doing much here since. The code is tested as far as the tests here go (so not much), but should mostly work (TM). |
marzipankaiser
force-pushed
the
feature/stdlib/mutable-darray-heap-uf
branch
from
72702b3 to
48bfc57
Compare
Co-authored-by: Jiří Beneš <[email protected]>
Co-authored-by: Jiří Beneš <[email protected]>
marzipankaiser
force-pushed
the
feature/stdlib/mutable-darray-heap-uf
branch
from
dc62953 to
597bded
Compare
|
Rebased, cleaned up a bit. Should be fine, except not tested well and not documented in too much detail, either. |
marzipankaiser
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For writing examples, I wanted to have some standard mutable data structures, currently:
They all still need more documentation, testing and maybe some additional functions (I only implemented what I needed).