Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup for #531 #535

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Cleanup for #531 #535

wants to merge 2 commits into from

Conversation

marzipankaiser
Copy link
Contributor

@marzipankaiser marzipankaiser commented Jul 31, 2024 •
edited
Loading

This fixes the things noted in #531 (mostly a draft PR so I don't forget):

  • Double-check whether we need to parenthesize objects or literals in certain places.
    • Yes, we have to:
      • objects
      • int and double literals
  • Delete double-parens in stdlib (hotfixes from earlier).

@b-studios
Copy link
Collaborator

Hey @marzipankaiser what do you want to do with this PR?

@jiribenes jiribenes force-pushed the master branch 3 times, most recently from ee9d209 to 58c8510 Compare October 1, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:js
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marzipankaiser @b-studios @jiribenes