Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flags jsNode and jsWeb #454

Merged
merged 9 commits into from
Jul 30, 2024
Merged

Conversation

marzipankaiser
Copy link
Contributor

@marzipankaiser marzipankaiser commented May 7, 2024

Currently distinguished by the Backend creating the JavaScript generator object (backend).
Untested.

@marzipankaiser
Copy link
Contributor Author

@jiribenes I vaguely remember you needed to change some things in the js code for your presentation tool - What was that again? We could integrate those changes here for the JSWeb backend.

@marzipankaiser
Copy link
Contributor Author

This is related to #405: When introducing a js-web backend, we should have js code that can run in the browser.

@marzipankaiser marzipankaiser force-pushed the feature/js-web-node-ff branch from d54bcb8 to af71adc Compare June 25, 2024 14:38
@b-studios
Copy link
Collaborator

b-studios commented Jun 27, 2024

Maybe this also needs to be changed, when merging this PR: http://effekt-lang.org/docs/getting-started#compiling-programs-with-effekt

@marzipankaiser
Copy link
Contributor Author

marzipankaiser commented Jun 28, 2024

Maybe this also needs to be changed, when merging this PR: http://effekt-lang.org/docs/getting-started#compiling-programs-with-effekt

This should remain unchanged - apart from some names in code, the js (node) backend stays the same.
That is, unless we want to also say something about js-web.

@marzipankaiser marzipankaiser marked this pull request as ready for review June 28, 2024 07:26
@marzipankaiser
Copy link
Contributor Author

Marking this as ready for review. - While interrelated to #511, the hotfix works for now™️ and this could be merged first. Then, we could also start adjusting the stdlib where appropriate.

Do not suggest that we will add support to run directly. I don't think we ever want that.
@b-studios b-studios merged commit 77772aa into master Jul 30, 2024
2 checks passed
@b-studios b-studios deleted the feature/js-web-node-ff branch July 30, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants