Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotMorten lib is not needed, and this is not a bug fix. #117

Closed
wants to merge 24 commits into from
Closed

dotMorten lib is not needed, and this is not a bug fix. #117

wants to merge 24 commits into from

Conversation

mehdihaghshenas
Copy link

@mehdihaghshenas mehdihaghshenas commented Nov 13, 2022 •
edited
Loading

No description provided.

@ErikEJ
Copy link
Member

ErikEJ commented Nov 13, 2022

This library should use the official Microsoft.SqlServer.Types package.

@ErikEJ
Copy link
Member

ErikEJ commented Nov 13, 2022

Also EF Core 7 targets .NET 6

@mehdihaghshenas
Copy link
Author

This library should use the official Microsoft.SqlServer.Types package.

but https://www.nuget.org/packages/Microsoft.SqlServer.Types/ only support dot net 4.x

@ErikEJ
Copy link
Member

ErikEJ commented Nov 13, 2022

No, the latest version supports .NET Standard 2.1 https://www.nuget.org/packages/Microsoft.SqlServer.Types/160.900.6-rc0#supportedframeworks-body-tab

@mehdihaghshenas
Copy link
Author

No, the latest version supports .NET Standard 2.1 https://www.nuget.org/packages/Microsoft.SqlServer.Types/160.900.6-rc0#supportedframeworks-body-tab

Thank you so much

@mehdihaghshenas
Copy link
Author

@bricelam
can you publish a new version of this package
we have problem to use rc version with EF 7.0.0

@ErikEJ
Copy link
Member

ErikEJ commented Nov 15, 2022

Suggest you update the title and initial comment on this PR - dotMorten lib is not needed, and this is not a bug fix.

@mehdihaghshenas mehdihaghshenas changed the title Fix bugs after upgrade to EF 7.0 dotMorten lib is not needed, and this is not a bug fix. Nov 15, 2022
@bricelam
Copy link
Member

New versions have been uploaded to NuGet.org. See #113 for switching to the official SqlServer.Types package

@bricelam bricelam closed this Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikEJ ErikEJ ErikEJ left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mehdihaghshenas @ErikEJ @bricelam