Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gpio_test.c #313

Closed
wants to merge 1 commit into from
Closed

Update gpio_test.c #313

wants to merge 1 commit into from

Conversation

mattvenn
Copy link
Contributor

fixes #311

@mattvenn
Copy link
Contributor Author

Also, I would like to encourage the team to include these tests in the CI.

@M0stafaRady M0stafaRady self-requested a review October 16, 2023 07:35
M0stafaRady
M0stafaRady approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@M0stafaRady M0stafaRady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@M0stafaRady
Copy link
Member

We are working on the CI.

@marwaneltoukhy marwaneltoukhy added the duplicate This issue or pull request already exists label Oct 23, 2023
@marwaneltoukhy
Copy link
Member

This has been fixed in #317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M0stafaRady M0stafaRady M0stafaRady approved these changes

@marwaneltoukhy marwaneltoukhy marwaneltoukhy approved these changes

Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cocotb gpio test broken
3 participants
@mattvenn @M0stafaRady @marwaneltoukhy