Corrected the set_user_id.py script to put the bits in the correct direction. #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
direction when casting from an integer to a binary string. This is the same correction that was made to caravel-gf180mcu some time ago. Thanks to Mitch Bailey for finding and reporting the issue.
|
@jeffdi : Please review and merge. See issue #516 for reference (attn. @d-m-bailey , who I would like to add as a reviewer but somehow can't). @jeffdi : Can Mitch be added as a member of the Efabless repositories with permission to post and review pull requests? |
|
2 lines need to be changed. See my pull request. Please don't use this one. |
|
Closing this PR because it is superseded by #518. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the set_user_id.py script to put the bits in the correct direction when casting from an integer to a binary string. This is the same correction that was made to caravel-gf180mcu some time ago. Thanks to Mitch Bailey for finding and reporting the issue. This solves issue #516.