Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove previous LVS results before making lvs-* and lvs-gds-* targets. #138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

d-m-bailey
Copy link
Contributor

This fixes an issue on caravel_user_project where previous correct lef lvs results were used when gds lvs failed.

caravel_user_project issue

This has been tested by copying caravel/openlane/digital_pll to openlane/digital_pll and copying digital_pll.v, digital_pll_controller.v, and ring_osc2x13.v from caravel/verilog/rtl to verilog/rtl/. Use netgen 1.5.228

Before change

make  digital_pll
make lvs-digital_pll
(lef lvs passes)
rm gds/digital_pll.gds*
touch gds/digital_pll.gds
make lvs-gds-digital_pll
(gds lvs fails, but finishes without errors)

After change

make  digital_pll
make lvs-digital_pll
(lef lvs passes)
rm gds/digital_pll.gds*
touch gds/digital_pll.gds
make lvs-gds-digital_pll
(make fails)

Copy link
Contributor

@RTimothyEdwards RTimothyEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, although it looks like all of these Makefile recipes are leaving behind "tmp" directories without cleaning them up afterward. Makes more sense to remove them at the end of each recipe (as well as at the beginning, as a precaution).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flow Makefile or in-repository flow script changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants