Skip to content

Commit

Permalink
test: trying prod target for dev image to narrow down provision issue
Browse files Browse the repository at this point in the history
  • Loading branch information
huniafatima-arbi committed Oct 7, 2024
1 parent 6911523 commit 4611a00
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/push-registrar-image.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
with:
file: ./dockerfiles/registrar.Dockerfile
push: true
target: prod
target: dev
tags: edxops/registrar-dev:${{ steps.get-tag-name.outputs.result }}

- name: Send failure notification
Expand Down
4 changes: 2 additions & 2 deletions dockerfiles/registrar.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ EXPOSE 18735
FROM app as dev

Check warning on line 74 in dockerfiles/registrar.Dockerfile

View workflow job for this annotation

GitHub Actions / build-and-push-image

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

# fetching the requirement file that is needed
RUN curl -L -o devstack.txt https://raw.githubusercontent.com/edx/registrar/master/requirements/devstack.txt
RUN curl -L -o production.txt https://raw.githubusercontent.com/edx/registrar/master/requirements/production.txt

RUN pip install --no-cache-dir -r ${REGISTRAR_CODE_DIR}/devstack.txt
RUN pip install --no-cache-dir -r ${REGISTRAR_CODE_DIR}/production.txt

# cloning the repository after requirements installation
RUN curl -L https://github.com/edx/registrar/archive/refs/heads/master.tar.gz | tar -xz --strip-components=1
Expand Down

0 comments on commit 4611a00

Please sign in to comment.