Migrate commons.logging and log4j-1 loggers to SLF4J #296
+130
−185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of the work to unify the logging frameworks used in MWE to use only slf4j and at the same time to migrate off commons.logging and log4j-1.
Currently this only contains the changes in java-code and the removal of the then obsolete logging frameworks from the target-platform, features, etc.
What's missing is the migration of the (log4j-1) configuration and the addition of a logging back-end slf4j can use.
My suggestion is to use slf4j-simple as a back-end.
The changes to adapt the projects that contain workflows to generate for example xtext DSLs are also missing because I don't know yet where to change that.
Furthermore the log4j.properties have to be migrated to the back-end chosen eventually. E.g. for slf4j-simple the doc is:
https://www.slf4j.org/api/org/slf4j/simple/SimpleLogger.html
This would help to solve eclipse/xtext#3127 at MWE side.
@cdietrich what do you think?