Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement unicast DNS-SD #61

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: implement unicast DNS-SD #61

wants to merge 3 commits into from

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Oct 27, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (1fd9a64) 60.41% compared to head (dd3a878) 51.67%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   60.41%   51.67%   -8.74%     
==========================================
  Files          70       70              
  Lines        2185     2210      +25     
==========================================
- Hits         1320     1142     -178     
- Misses        865     1068     +203     
Files Coverage Δ
lib/src/core/thing_discovery.dart 0.00% <0.00%> (ø)

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (0badb0b) 65.79% compared to head (c068f2a) 64.73%.

Files Patch % Lines
lib/src/core/implementation/thing_discovery.dart 0.00% 46 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   65.79%   64.73%   -1.06%     
==========================================
  Files          74       74              
  Lines        2383     2422      +39     
==========================================
  Hits         1568     1568              
- Misses        815      854      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JKRhb JKRhb force-pushed the dns-discovery branch 2 times, most recently from 938c7c5 to c068f2a Compare January 27, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants