Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed reload for remote feature and added option to the electron window to add change url on reload #13891

Merged

Conversation

jonah-iden
Copy link
Contributor

What it does

This fixes the remote feature when connecting current window to remote instance.
Had to add the option for the electron window reload to add a new url.

Fixes #13888

How to test

Best tested with dev containers. Simple file like this should be enough.

{
    "image": "mcr.microsoft.com/devcontainers/typescript-node:0-18",
    "forwardPorts": [3000]
}

"Reopen in Container" command should now again work as expected

Follow-ups

Review checklist

Reminder for reviewers

@JonasHelming JonasHelming requested a review from planger July 8, 2024 08:06
Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I tested the change with the steps mentioned in the description. Works well and code looks good too. 💯

@jonah-iden jonah-iden merged commit 10b156c into eclipse-theia:master Jul 9, 2024
11 of 14 checks passed
@jonah-iden jonah-iden deleted the jiden/fix-remote-feature-reload branch July 9, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Dev containers does not work (no errors, no logs, no visual state)
2 participants