Add maxAccelProfile and desAccelProfile to CF-models #14339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominik Salles <[email protected]>
Signed-off-by: Dominik Salles <[email protected]>
…r all CF-models Signed-off-by: Dominik Salles <[email protected]>
Signed-off-by: Dominik Salles <[email protected]>
|
Same here: Can you estimate when this will be integrated? |
This won't make it into 1.21.0 sorry. 1.22.0 should be doable. |
|
no problem, thanks for the update! I published a paper using this feature and just wanted it to be available for everybody. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seperated
maxAccel(physically possible acceleration) fromdesAccel(speed-dependent, non-constant myAccel).Both profiles need to be written in the form of
"speed1 accel1, speed2 accel2, speed3 accel3, ...".It works/is intended to work as follows:
maxAccelProfile: These acceleration values represent the physically possible acceleration at a specific speed. If a CF-model calculates the possible acceleration depending on vehicle resistance, then these values shall be used. When the maxAccel-value becomes lower than the desAccel value, the actual accel-value gets reduced.desAccelProfile: These acceleration values represent the desired acceleration at a specific speed. As "dummy" value, the acceleration output is equal tomyAccel.Solves #3920 for the EIDM, but needs to be added separately for the other models.