Mark loop end label as end-of-internal-control-flow label #20849
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The label that marked the beginning of a loop that handles residual bytes for the inline implementation of ArraysSupport.vectorizedHashCode was incorrectly marked as both the Start and End of internal control flow. The end loop label should have been marked as the End of internal control flow. Signed-off-by: Henry Zongaro <[email protected]>
|
@vijaysun-omr, may I ask you to review this change? It should only affect JDK 21 and 23 on x86. Jenkins test sanity.functional,sanity.openjdk xlinux,xmac jdk21,jdk23 |
vijaysun-omr
approved these changes
Dec 18, 2024
|
I have approved, since it is clearly a typo being fixed. |
|
The JDK 23 xlinux sanity.functional test failure appears to be due to known issue #18920 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The label that marked the beginning of a loop that handles residual bytes for the inline implementation of ArraysSupport.vectorizedHashCode was incorrectly marked as both the Start and End of internal control flow. The end loop label should have been marked as the End of internal control flow.
Fixes #20786