Return from park immediately for non-positive time since epoch #20802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithc-ca
requested changes
Dec 10, 2024
runtime/vm/threadpark.cpp
Outdated
Comment on lines
53
to
55
| /* Currently, the omrthread layer provides no direct support for absolute timeouts. | ||
| * Simulate the timeout by calculating the delta from the current time. | ||
| */ |
There was a problem hiding this comment.
Please correct the indentation of lines 54, 55.
runtime/vm/threadpark.cpp
Outdated
| * Simulate the timeout by calculating the delta from the current time. | ||
| */ | ||
| PORT_ACCESS_FROM_VMC(vmThread); | ||
| if () |
There was a problem hiding this comment.
I assume this was added in error.
runtime/vm/threadpark.cpp
Outdated
| @@ -47,18 +47,23 @@ threadParkImpl(J9VMThread *vmThread, BOOLEAN timeoutIsEpochRelative, I_64 timeou | |||
| /* Trc_JCL_park_Entry(vmThread, timeoutIsEpochRelative, timeout); */ | |||
| if ((0 != timeout) || (timeoutIsEpochRelative)) { | |||
There was a problem hiding this comment.
While you're here, please remove the redundant parentheses:
if ((0 != timeout) || timeoutIsEpochRelative) {
runtime/vm/threadpark.cpp
Outdated
| /*Trc_JCL_park_timeIsInPast(vmThread, timeNow);*/ | ||
| if (millis <= 0) { | ||
| rc = J9THREAD_TIMED_OUT; | ||
| /*Trc_JCL_park_timeIsInPast(vmThread, timeNow);*/ |
There was a problem hiding this comment.
Please add spaces in the comment (see line 47):
/* Trc_JCL_park_timeIsInPast(vmThread, timeNow); */
|
Rather than "negative" the description should say "non-positive", unless the intent was "negative" in which case the code needs to be corrected. |
theresa-m
changed the title
Signed-off-by: Theresa Mammarella <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the deadline since epoch given to Unsafe.park is negative the calculation of
millscould overflow. To prevent this set the return code toJ9THREAD_TIMED_OUTfor non-positive deadlines since they have always passed.Related to: #17135