Print actual string arguments with -Xtrace (part 2) #20662
Merged
+65
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h3110n3rv3
changed the title
|
@TobiAjila could you please review for comments/concerns/feedback? Thanks |
h3110n3rv3
changed the title
h3110n3rv3
changed the title
h3110n3rv3
changed the title
h3110n3rv3
force-pushed
the
Feature-request-16416-part2
branch
3 times, most recently
from
6f968b4 to
2a77535
Compare
tajila
reviewed
Nov 28, 2024
tajila
reviewed
Nov 28, 2024
tajila
reviewed
Nov 28, 2024
tajila
reviewed
Dec 4, 2024
runtime/rastrace/j9rastrace.h
Outdated
| #define RAS_STACKDEPTH_KEYWORD "STACKDEPTH" | ||
| #define RAS_SLEEPTIME_KEYWORD "SLEEPTIME" | ||
| #define RAS_COMPRESSION_LEVEL_KEYWORD "STACKCOMPRESSIONLEVEL" | ||
| #define RAS_METHOD_STRING_LENGTH_KEYWORD "METHODSTRARGLEN" |
There was a problem hiding this comment.
maybe "MAXSTRINGLENGTHINMETHODPARAMETER"
There was a problem hiding this comment.
then RAS_MAX_STRING_LENGTH_IN_METHOD_PARAMTER
tajila
approved these changes
Dec 4, 2024
|
@keithc-ca Please review these changes |
keithc-ca
requested changes
Dec 4, 2024
h3110n3rv3
force-pushed
the
Feature-request-16416-part2
branch
from
4a285f2 to
0b4ffe9
Compare
keithc-ca
requested changes
Dec 9, 2024
h3110n3rv3
force-pushed
the
Feature-request-16416-part2
branch
from
66dcb5c to
50e2f3d
Compare
h3110n3rv3
changed the title
|
Jenkins test sanity.functional amac jdk11 |
|
The output of For the record, testing is underway at https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/6690. |
keithc-ca
reviewed
Dec 10, 2024
runtime/rastrace/method_trigger.c
Outdated
| return OMR_ERROR_NONE; | ||
| } | ||
| err: | ||
| vaReportJ9VMCommandLineError(PORTLIB, "maxstringlength takes an integer value from 1 to %d", RAS_MAX_STRING_LENGTH_LIMIT); |
There was a problem hiding this comment.
The lower bound is 0, not 1.
h3110n3rv3
force-pushed
the
Feature-request-16416-part2
branch
from
422c017 to
956106f
Compare
The changes reflect the feature request eclipse-openj9#16416. Adding cmdline option to specify string argument length. -Xtrace:maxstringlength=[1-128] maxstringlength takes an unsigned integer value from 1 to 128 If maxstringlength = 0 or unspecified, default to address printing. Other invalid inputs result in the input error. There will be subsequent PR for tests (part 3). Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3
force-pushed
the
Feature-request-16416-part2
branch
from
3dd98d3 to
686f6ce
Compare
tajila
approved these changes
Dec 16, 2024
|
jenkins test sanity alinux jdk21 |
|
jenkins test sanity alinux64 jdk21 |
|
jenkins test sanity win jdk8 |
|
jenkins test sanity alinux64 jdk21 |
|
jenkins test sanity win jdk8 |
|
jenkins test sanity plinux jdk8 |
h3110n3rv3
added a commit
to h3110n3rv3/openj9
that referenced
this pull request
Dec 17, 2024
The changes reflect the feature request eclipse-openj9#16416 - part 3 following eclipse-openj9#20662 cmdline tests for -Xtrace:maxstringlength Closes: eclipse-openj9#16416 Signed-off-by: Nick Kamal [email protected]
h3110n3rv3
added a commit
to h3110n3rv3/openj9
that referenced
this pull request
Dec 17, 2024
The changes reflect the feature request eclipse-openj9#16416 - part 3 following eclipse-openj9#20662 cmdline tests for -Xtrace:maxstringlength Closes: eclipse-openj9#16416 Signed-off-by: Nick Kamal [email protected]
h3110n3rv3
added a commit
to h3110n3rv3/openj9
that referenced
this pull request
Dec 17, 2024
The changes reflect the feature request eclipse-openj9#16416 - part 3 following eclipse-openj9#20662 cmdline tests for -Xtrace:maxstringlength Closes: eclipse-openj9#16416 Signed-off-by: Nick Kamal [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes reflect the feature request #16416.
Adding cmdline option to specify string argument length.
-Xtrace:maxstringlength=[0-128]
maxstringlength takes an unsigned integer value from 0 to 128
If maxstringlength = 0 or unspecified, default to address printing.
Other invalid inputs result in the input error.
There will be subsequent PR for tests (part 3).
Signed-off-by: Nick Kamal <[email protected]>