Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Provide a means to capture contents of String arguments and return values with Xtrace #16416

Open
paulcheeseman opened this issue Dec 5, 2022 · 6 comments · May be fixed by #20681
Open

Feature Request: Provide a means to capture contents of String arguments and return values with Xtrace #16416

paulcheeseman opened this issue Dec 5, 2022 · 6 comments · May be fixed by #20681
Assignees
@h3110n3rv3
Labels
comp:ras comp:vm userRaised

Comments

@paulcheeseman
Copy link

It's not currently possible to capture the contents of String arguments and return values when tracing methods with Xtrace. All you get is the address of the String object.

For example:

11:19:45.789 0x8aff00              mt.0            > java/lang/String.equals(Ljava/lang/Object;)Z bytecode method, this = 0xdfff3d68
11:19:45.789 0x8aff00              mt.18            - this: java/lang/String@00000000DFFF3D68 method arguments: (java/lang/String@00000000DFFF3D90)

and:

11:21:37.654 0x8aff00              mt.6            < java/lang/StringBuilder.toString()Ljava/lang/String; bytecode method
11:21:37.654 0x8aff00              mt.28           - return value: java/lang/String@00000000FFF2C408

There are many situations in which it would be useful to be able to capture the actual contents of the String objects - something like this, for example:

11:19:45.789 0x8aff00              mt.0            > java/lang/String.equals(Ljava/lang/Object;)Z bytecode method, this = 0xdfff3d68
11:19:45.789 0x8aff00              mt.18            - this: java/lang/String@00000000DFFF3D68[Hello world] method arguments: (java/lang/String@00000000DFFF3D90[Hello World])

The only alternatives right now are to modify the application code (to add println() calls), either by changing the source code and rebuilding or instrumenting the code with an agent, or to trigger a core dump on the relevant method call and retrieve the String(s) from that.

I suspect there would be a significant performance cost associated with retrieving the String contents, so this certainly isn't something that we would want to enable by default, but it would be great to have the option. The alternative approaches are almost certainly costlier - modifying application code is typically not trivial (especially in production), third party code often cannot be modified at all, and writing a core dump typically suspends the application for at least several seconds.

It might also be useful to be able to trace the contents of primitive arrays as well (e.g. char[] and byte[]).

It's very likely that this functionality has been considered and rejected in the past, but I couldn't find any previous conversations on this topic. In the worst case this Github issue can at least provide a record of why this isn't feasible.
@pshipton
Copy link
Member

pshipton commented Dec 5, 2022

@keithc-ca @tajila fyi

@tajila tajila added the comp:ras label Dec 5, 2022
@gacholio
Copy link
Contributor

gacholio commented Dec 6, 2022

The immediate problem I see with this is that the string data may be huge. I don't know that tracepoints can handle data that's larger than the trace buffer blocks.

@keithc-ca
Copy link
Contributor

We already have Trc_BCU_internalDefineClass_FullData which captures the bytecode for an entire class.
We could capture the length and a prefix of strings, byte and char arrays (with an option to control the length of that prefix).

@paulcheeseman
Copy link
Author

The immediate problem I see with this is that the string data may be huge. I don't know that tracepoints can handle data that's larger than the trace buffer blocks.

Yes, I thought that might be a problem too.

We could capture the length and a prefix of strings, byte and char arrays (with an option to control the length of that prefix).

Yes, I was thinking of something similar to how strace's -s option works, e.g. with the default string length of 32:

21927 write(3, "0x7F\n", 5)             = 5
21927 write(2, "java version \"1.8.0_321\"", 24) = 24
21927 write(2, "\n", 1)                 = 1
21927 write(2, "Java(TM) SE Runtime Environment "..., 84) = 84
21927 write(2, "\n", 1)                 = 1
21927 write(2, "IBM J9 VM (build 2.9, JRE 1.8.0 "..., 172) = 172
21927 write(2, "\n", 1)                 = 1
21927 write(2, "JCL - 20220120_01 based on Oracl"..., 46) = 46
21927 write(2, "\n", 1)                 = 1

I guess the maximum string length would be about the same size as the thread's trace buffer (probably slightly smaller)?

@jasonkatonica
Copy link
Contributor

We have a client who we are trying to help audit their use of cryptography. We wanted to print the algorithm passed into a particular method to create a very primative audit trace.

In this case we wanted to audit the javax/crypto/Cipher.getInstance(String) method and print the String value passed as an argument to the method. I have had some success with a trace similar to follows :

-Xtrace:'print=mt,maximal=mt,trigger=method{javax/crypto/Cipher.getInstance,jstacktrace}' -Xjit:'exclude={javax/crypto/},dontinline={javax/crypto/}' PKCS12Example.java

which results in something like the following:

16:33:43.659*0x17000              mt.3        > javax/crypto/Cipher.getInstance(Ljava/lang/String;)Ljavax/crypto/Cipher; bytecode static method
16:33:43.660 0x17000       j9trc_aux.0        - jstacktrace:
16:33:43.660 0x17000       j9trc_aux.1        - [1] javax.crypto.Cipher.getInstance (Cipher.java:534)
16:33:43.660 0x17000       j9trc_aux.1        - [2] sun.security.pkcs12.PKCS12KeyStore.lambda$engineLoad$1 (PKCS12KeyStore.java:2086)
16:33:43.660 0x17000       j9trc_aux.1        - [3] sun.security.pkcs12.PKCS12KeyStore$$Lambda.0x0000000000000000.tryOnce (Bytecode PC: 13)
16:33:43.660 0x17000       j9trc_aux.1        - [4] sun.security.pkcs12.PKCS12KeyStore$RetryWithZero.run (PKCS12KeyStore.java:257)
16:33:43.660 0x17000       j9trc_aux.1        - [5] sun.security.pkcs12.PKCS12KeyStore.engineLoad (PKCS12KeyStore.java:2084)
16:33:43.660 0x17000       j9trc_aux.1        - [6] sun.security.util.KeyStoreDelegator.engineLoad (KeyStoreDelegator.java:228)
16:33:43.660 0x17000       j9trc_aux.1        - [7] java.security.KeyStore.load (KeyStore.java:1500)
16:33:43.660 0x17000       j9trc_aux.1        - [8] com.ibm.example.pkcs12.PKCS12Example.main (PKCS12Example.java:18)
16:33:43.660 0x17000       j9trc_aux.1        - [9] java.lang.invoke.LambdaForm$DMH.0x000000005032ba10.invokeStatic (LambdaForm$DMH)
16:33:43.660 0x17000       j9trc_aux.1        - [10] java.lang.invoke.LambdaForm$MH.0x00000000506f65b0.invoke (LambdaForm$MH)
16:33:43.660 0x17000       j9trc_aux.1        - [11] java.lang.invoke.LambdaForm$MH.0x00000000506f6b50.invokeExact_MT (LambdaForm$MH)
16:33:43.660 0x17000       j9trc_aux.1        - [12] jdk.internal.reflect.DirectMethodHandleAccessor.invokeImpl (DirectMethodHandleAccessor.java:154)
16:33:43.660 0x17000       j9trc_aux.1        - [13] jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:103) (Compiled Code)
16:33:43.660 0x17000       j9trc_aux.1        - [14] java.lang.reflect.Method.invoke (Method.java:586)
16:33:43.660 0x17000       j9trc_aux.1        - [15] com.sun.tools.javac.launcher.Main.execute (Main.java:484)
16:33:43.660 0x17000       j9trc_aux.1        - [16] com.sun.tools.javac.launcher.Main.run (Main.java:208)
16:33:43.660 0x17000       j9trc_aux.1        - [17] com.sun.tools.javac.launcher.Main.main (Main.java:135)
16:33:43.674 0x17000              mt.9        < javax/crypto/Cipher.getInstance(Ljava/lang/String;)Ljavax/crypto/Cipher; bytecode static method

However this does not print out the actual arguments to the method which we are attempting to record so we were unable to achieve our goal. The feature request in this issue would allow us to do this.

@h3110n3rv3
Copy link
Contributor

@tajila

h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Nov 18, 2024
@h3110n3rv3
Update to print String arguments with Xtrace
6553cac 
The changes reflect the feature request eclipse-openj9#16416.

Instead of printing the memory address for string arguments, print the actual string at max of 255 characters.

Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal<[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Nov 18, 2024
@h3110n3rv3
Update to print String arguments with Xtrace
8407258 
The changes reflect the feature request eclipse-openj9#16416.

Instead of printing the memory address for string arguments, print the actual string at max of 255 characters.

Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal<[email protected]>
@h3110n3rv3 h3110n3rv3 mentioned this issue Nov 19, 2024
Closed
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Nov 19, 2024
@h3110n3rv3
The changes reflect the feature request eclipse-openj9#16416.
5f6daa8 
Instead of printing the memory address for string arguments, print the actual string at max of 255 characters.

Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal <[email protected]>
@h3110n3rv3 h3110n3rv3 mentioned this issue Nov 19, 2024
Merged
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Nov 20, 2024
@h3110n3rv3
The changes reflect the feature request eclipse-openj9#16416.
ca304aa 
Instead of printing the memory address for string arguments, print the actual string at max of 255 characters.

Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Nov 20, 2024
@h3110n3rv3
The changes reflect the feature request eclipse-openj9#16416.
ae49bd0 
Instead of printing the memory address for string arguments, print the actual string at max of 255 characters.

Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Nov 20, 2024
@h3110n3rv3
The changes reflect the feature request eclipse-openj9#16416.
9941812 
Instead of printing the memory address for string arguments, print the actual string at max of 255 characters.

Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Nov 21, 2024
@h3110n3rv3
The changes reflect the feature request eclipse-openj9#16416.
eba9690 
Instead of printing the memory address for string arguments, print the actual string at max of 32 characters.
There will be subsequent PRs for cmdline option for string length and tests.

Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Nov 21, 2024
@h3110n3rv3
The changes reflect the feature request eclipse-openj9#16416.
ed27c15 
Instead of printing the memory address for string arguments, print the actual string at max of 32 characters.
There will be subsequent PRs for cmdline option for string length and tests.

Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Nov 21, 2024
@h3110n3rv3
The changes reflect the feature request eclipse-openj9#16416.
9f8b981 
Instead of printing the memory address for string arguments, print the actual string at max of 32 characters.
There will be subsequent PRs for cmdline option for string length and tests.

Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Nov 21, 2024
@h3110n3rv3
The changes reflect the feature request eclipse-openj9#16416.
343c787 
Instead of printing the memory address for string arguments, print the actual string at max of 32 characters.
There will be subsequent PRs for cmdline option for string length and tests.

Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Nov 21, 2024
@h3110n3rv3
Feature request: Print actual String arguments with Xtrace part 1
2c11a5c 
The changes reflect the feature request eclipse-openj9#16416.

Instead of printing the memory address for string arguments, print the actual string at max of 32 characters.
There will be subsequent PRs for cmdline option for string length (Part 2) and tests (Part 3).

Signed-off-by: Nick Kamal [email protected]
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Nov 21, 2024
@h3110n3rv3
The changes reflect the feature request eclipse-openj9#16416 - part 2…
15797e8 
… of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal <[email protected]>
@h3110n3rv3 h3110n3rv3 mentioned this issue Nov 21, 2024
Merged
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Nov 21, 2024
@h3110n3rv3
The changes reflect the feature request eclipse-openj9#16416 - part 2…
b860ff4 
… of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Nov 21, 2024
@h3110n3rv3
The changes reflect the feature request eclipse-openj9#16416 - part 2…
619a8b7 
… of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Nov 21, 2024
@h3110n3rv3
The changes reflect the feature request eclipse-openj9#16416 - part 2…
c8b0ab7 
… of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Nov 21, 2024
@h3110n3rv3
The changes reflect the feature request eclipse-openj9#16416 - part 2…
79032b6 
… of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Nov 21, 2024
@h3110n3rv3
The changes reflect the feature request eclipse-openj9#16416.
55aa497 
Print the actual string instead of address at max of 32 characters.
Subsequent PRs: cmdline option for length (Part 2) and tests (Part 3).

Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
The changes reflect the feature request eclipse-openj9#16416 - part 3
44209db 
Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
cmdline tests for -Xtrace:methodstrarglen
f1a4e90 
Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
Revert "The changes reflect the feature request eclipse-openj9#16416 …
bdf717e 
…- part 3"

This reverts commit 44209db.
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
Revert "The changes reflect the feature request eclipse-openj9#16416 …
8cc617c 
…- part 2 following eclipse-openj9#20641"

This reverts commit 81ebf3b.
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
Revert "The changes reflect the feature request eclipse-openj9#16416 …
a1c9cb9 
…- part 2 of eclipse-openj9#20641"

This reverts commit 5fed7b4.
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
Revert "The changes reflect the feature request eclipse-openj9#16416 …
0c34ad3 
…- part 2 of eclipse-openj9#20641"

This reverts commit 9d207fb.
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
Revert "The changes reflect the feature request eclipse-openj9#16416 …
e4371c8 
…- part 2 of eclipse-openj9#20641"

This reverts commit 1d2c828.
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
Revert "The changes reflect the feature request eclipse-openj9#16416 …
027b027 
…- part 2 of eclipse-openj9#20641"

This reverts commit 582d967.
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
Revert "The changes reflect the feature request eclipse-openj9#16416 …
01d6258 
…- part 2 of eclipse-openj9#20641"

This reverts commit 148a6de.
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
Feature request: Print actual String arguments with Xtrace part 1
e5ef9f3 
The changes reflect the feature request eclipse-openj9#16416.

Instead of printing the memory address for string arguments, print the actual string at max of 32 characters.
There will be subsequent PRs for cmdline option for string length (Part 2) and tests (Part 3).

Signed-off-by: Nick Kamal [email protected]
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
The changes reflect the feature request eclipse-openj9#16416 - part 2…
5898f9c 
… of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
The changes reflect the feature request eclipse-openj9#16416 - part 2…
ddd602a 
… of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
The changes reflect the feature request eclipse-openj9#16416 - part 2…
e645803 
… of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
The changes reflect the feature request eclipse-openj9#16416 - part 2…
40b6792 
… of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
The changes reflect the feature request eclipse-openj9#16416 - part 2…
17eff65 
… of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
Print actual String arguments with Xtrace part 1
e1e0982 
The changes reflect the feature request eclipse-openj9#16416.

Print the actual string instead of address at max of 32 characters.
Subsequent PRs: cmdline option for length (Part 2) and tests (Part 3).

Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
The changes reflect the feature request eclipse-openj9#16416 - part 2…
95ac521 
… following eclipse-openj9#20641

Adding cmdline option to specify string argument length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 1 to 128
Trace option unrecognized: -Xtrace:methodStrArgLen
Error processing trace option: -Xtrace:methodStrArgLen=invalid input"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
The changes reflect the feature request eclipse-openj9#16416 - part 3
1866b5d 
Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
cmdline tests for -Xtrace:methodstrarglen
fe69582 
Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
Revert "The changes reflect the feature request eclipse-openj9#16416 …
7240761 
…- part 3"

This reverts commit 44209db.
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
Revert "The changes reflect the feature request eclipse-openj9#16416 …
b81e09b 
…- part 2 following eclipse-openj9#20641"

This reverts commit 81ebf3b.
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
Revert "The changes reflect the feature request eclipse-openj9#16416 …
f1fadee 
…- part 2 of eclipse-openj9#20641"

This reverts commit 5fed7b4.
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
Revert "The changes reflect the feature request eclipse-openj9#16416 …
8fddf5a 
…- part 2 of eclipse-openj9#20641"

This reverts commit 9d207fb.
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
Revert "The changes reflect the feature request eclipse-openj9#16416 …
69e1624 
…- part 2 of eclipse-openj9#20641"

This reverts commit 1d2c828.
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
Revert "The changes reflect the feature request eclipse-openj9#16416 …
cb02324 
…- part 2 of eclipse-openj9#20641"

This reverts commit 582d967.
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
Revert "The changes reflect the feature request eclipse-openj9#16416 …
8986d11 
…- part 2 of eclipse-openj9#20641"

This reverts commit 148a6de.
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
Feature request: Print actual String arguments with Xtrace part 1
12fb0d5 
The changes reflect the feature request eclipse-openj9#16416.

Instead of printing the memory address for string arguments, print the actual string at max of 32 characters.
There will be subsequent PRs for cmdline option for string length (Part 2) and tests (Part 3).

Signed-off-by: Nick Kamal [email protected]

The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal <[email protected]>

The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>

The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>

The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>

The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>

Print actual String arguments with Xtrace part 1

The changes reflect the feature request eclipse-openj9#16416.

Print the actual string instead of address at max of 32 characters.
Subsequent PRs: cmdline option for length (Part 2) and tests (Part 3).

Signed-off-by: Nick Kamal <[email protected]>

The changes reflect the feature request eclipse-openj9#16416 - part 2 following eclipse-openj9#20641

Adding cmdline option to specify string argument length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 1 to 128
Trace option unrecognized: -Xtrace:methodStrArgLen
Error processing trace option: -Xtrace:methodStrArgLen=invalid input"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>

The changes reflect the feature request eclipse-openj9#16416 - part 3

Signed-off-by: Nick Kamal <[email protected]>

cmdline tests for -Xtrace:methodstrarglen

Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal <[email protected]>

Update xtraceTests.xml

Feature request: Print actual String arguments with Xtrace part 1

The changes reflect the feature request eclipse-openj9#16416.

Instead of printing the memory address for string arguments, print the actual string at max of 32 characters.
There will be subsequent PRs for cmdline option for string length (Part 2) and tests (Part 3).

Signed-off-by: Nick Kamal [email protected]

The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal <[email protected]>

The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>

The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>

The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>

The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>

Print actual String arguments with Xtrace part 1

The changes reflect the feature request eclipse-openj9#16416.

Print the actual string instead of address at max of 32 characters.
Subsequent PRs: cmdline option for length (Part 2) and tests (Part 3).

Signed-off-by: Nick Kamal <[email protected]>

The changes reflect the feature request eclipse-openj9#16416 - part 2 following eclipse-openj9#20641

Adding cmdline option to specify string argument length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 1 to 128
Trace option unrecognized: -Xtrace:methodStrArgLen
Error processing trace option: -Xtrace:methodStrArgLen=invalid input"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>

The changes reflect the feature request eclipse-openj9#16416 - part 3

Signed-off-by: Nick Kamal <[email protected]>

cmdline tests for -Xtrace:methodstrarglen

Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal <[email protected]>

Update xtraceTests.xml

Revert "Update xtraceTests.xml"

This reverts commit a02170c.

Revert "cmdline tests for -Xtrace:methodstrarglen"

This reverts commit f1a4e90.

Revert "The changes reflect the feature request eclipse-openj9#16416 - part 3"

This reverts commit 44209db.

Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 following eclipse-openj9#20641"

This reverts commit 81ebf3b.

Revert "Print actual String arguments with Xtrace part 1"

This reverts commit c5ca003.

Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641"

This reverts commit 5fed7b4.

Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641"

This reverts commit 9d207fb.

Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641"

This reverts commit 1d2c828.

Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641"

This reverts commit 582d967.

Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641"

This reverts commit 148a6de.

Revert "Feature request: Print actual String arguments with Xtrace part 1"

This reverts commit 820e22e.

Feature request: Print actual String arguments with Xtrace part 1

The changes reflect the feature request eclipse-openj9#16416.

Instead of printing the memory address for string arguments, print the actual string at max of 32 characters.
There will be subsequent PRs for cmdline option for string length (Part 2) and tests (Part 3).

Signed-off-by: Nick Kamal [email protected]

The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal <[email protected]>

The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>

The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>

The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>

The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641

Adding cmdline option to specify string length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128
 Trace option unrecognized: -Xtrace:methodStrArgLen
 Error processing trace option: -Xtrace:methodStrArgLen=<invalid input>
"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>

Print actual String arguments with Xtrace part 1

The changes reflect the feature request eclipse-openj9#16416.

Print the actual string instead of address at max of 32 characters.
Subsequent PRs: cmdline option for length (Part 2) and tests (Part 3).

Signed-off-by: Nick Kamal <[email protected]>

The changes reflect the feature request eclipse-openj9#16416 - part 2 following eclipse-openj9#20641

Adding cmdline option to specify string argument length to be printed.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32.
Other invalid inputs result in the following:
"Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 1 to 128
Trace option unrecognized: -Xtrace:methodStrArgLen
Error processing trace option: -Xtrace:methodStrArgLen=invalid input"

There will be subsequent PRs for tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>

The changes reflect the feature request eclipse-openj9#16416 - part 3

Signed-off-by: Nick Kamal <[email protected]>

cmdline tests for -Xtrace:methodstrarglen

Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal <[email protected]>

Update xtraceTests.xml

Revert "Update xtraceTests.xml"

This reverts commit a02170c.

Revert "cmdline tests for -Xtrace:methodstrarglen"

This reverts commit f1a4e90.

Revert "The changes reflect the feature request eclipse-openj9#16416 - part 3"

This reverts commit 44209db.

Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 following eclipse-openj9#20641"

This reverts commit 81ebf3b.

Revert "Print actual String arguments with Xtrace part 1"

This reverts commit c5ca003.

Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641"

This reverts commit 5fed7b4.

Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641"

This reverts commit 9d207fb.

Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641"

This reverts commit 1d2c828.

Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641"

This reverts commit 582d967.

Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641"

This reverts commit 148a6de.

Revert "Feature request: Print actual String arguments with Xtrace part 1"

This reverts commit 820e22e.
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
Print actual String arguments with Xtrace part 3
e79650e 
The changes reflect the feature request eclipse-openj9#16416 - part 3 following eclipse-openj9#20662

cmdline tests for -Xtrace:maxstringlength

Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal [email protected]
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
Filter changed files Print actual String arguments with Xtrace part 3
affc411 
The changes reflect the feature request eclipse-openj9#16416 - part 3 following eclipse-openj9#20662

cmdline tests for -Xtrace:maxstringlength

Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal [email protected]
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Dec 17, 2024
@h3110n3rv3
Print actual String arguments with Xtrace part 3
956f827 
The changes reflect the feature request eclipse-openj9#16416 - part 3 following eclipse-openj9#20662

cmdline tests for -Xtrace:maxstringlength

Closes: eclipse-openj9#16416
Signed-off-by: Nick Kamal [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h3110n3rv3 h3110n3rv3

Labels
comp:ras comp:vm userRaised
Projects
None yet
Milestone
No milestone
7 participants
@tajila @keithc-ca @gacholio @pshipton @paulcheeseman @jasonkatonica @h3110n3rv3