Value Types: Fix VP constraint for null-restricted array class #7579
+35
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hzongaro May I ask you to review this change? Thank you! |
a7ehuo
changed the title
hzongaro
reviewed
Dec 4, 2024
a7ehuo
force-pushed
the
valuetype-fix-vp-constraint-for-nullRestrictedArray
branch
from
c197ea8 to
2cb7621
Compare
|
@hzongaro All comments are addressed. Ready for another review. Thank you! |
hzongaro
reviewed
Dec 18, 2024
If null-restricted array is enabled and the class is an array class, the null-restricted array class and the nullable array class share the same signature. The null-restricted array can be viewed as a sub-type of the nullable array. Therefore, the constraint cannot be fixed class. Related: eclipse-openj9/openj9#20522 Signed-off-by: Annabelle Huo <[email protected]>
a7ehuo
force-pushed
the
valuetype-fix-vp-constraint-for-nullRestrictedArray
branch
from
2cb7621 to
c51517f
Compare
|
@hzongaro All comments are addressed in c51517f. The downstream implementation is in eclipse-openj9/openj9#20853. Ready for another review. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If null-restricted array is enabled and the class is an array class, the null-restricted array class and the nullable array class share the same signature. The null-restricted array can be viewed as a sub-type of the nullable array. Therefore, the constraint cannot be fixed class.
Related: eclipse-openj9/openj9#20522