Make ActionDispatcher more easily customizable #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-fleck-at
force-pushed
the
feature/action-dispatcher
branch
from
501429e to
f3e64a8
Compare
tortmayr
approved these changes
Jun 18, 2024
tortmayr
requested changes
Jun 18, 2024
...clipse.glsp.server/src/org/eclipse/glsp/server/internal/actions/DefaultActionDispatcher.java
Show resolved
Hide resolved
martin-fleck-at
force-pushed
the
feature/action-dispatcher
branch
2 times, most recently
from
6d064d3 to
c17f5cd
Compare
- Extract thread creation and initialization out of constructor Contributed on behalf of Axon Ivy AG
martin-fleck-at
force-pushed
the
feature/action-dispatcher
branch
from
c17f5cd to
762337d
Compare
ivy-cst
reviewed
Jun 18, 2024
There was a problem hiding this comment.
@martin-fleck-at Cool, thanks for the fast improvement 👍 .
Just one concern with the private methods
...clipse.glsp.server/src/org/eclipse/glsp/server/internal/actions/DefaultActionDispatcher.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
How to test
Follow-ups
Changelog