211: Address review comments

- Omit the "Default" prefix in the action handler name - Fix incorrect type for CheckEdgeTargetResultAction
eclipse-glsp · Sep 11, 2023 · d96c242 · d96c242
1 parent bdff55f
commit d96c242
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/....eclipse.glsp.server/src/org/eclipse/glsp/server/actions/CheckEdgeTargetResultAction.java b/....eclipse.glsp.server/src/org/eclipse/glsp/server/actions/CheckEdgeTargetResultAction.java
@@ -20,7 +20,7 @@
  */
 public class CheckEdgeTargetResultAction extends ResponseAction {
 
-   public static final String KIND = "setTargetTypeHints";
+   public static final String KIND = "checkEdgeTargetResult";
 
    private boolean isValid;
 

diff --git a/plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/di/DiagramModule.java b/plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/di/DiagramModule.java
@@ -44,7 +44,7 @@
 import org.eclipse.glsp.server.di.scope.DiagramGlobalScope;
 import org.eclipse.glsp.server.di.scope.DiagramGlobalSingleton;
 import org.eclipse.glsp.server.diagram.DiagramConfiguration;
-import org.eclipse.glsp.server.diagram.DefaultRequestTargetTypeHintsActionHandler;
+import org.eclipse.glsp.server.diagram.RequestTargetTypeHintsActionHandler;
 import org.eclipse.glsp.server.diagram.RequestTypeHintsActionHandler;
 import org.eclipse.glsp.server.diagram.ServerConfigurationContribution;
 import org.eclipse.glsp.server.diagram.SetTypeHintsAction;
@@ -341,7 +341,7 @@ protected void configureActionHandlers(final MultiBinding<ActionHandler> binding
       binding.add(ComputedBoundsActionHandler.class);
       binding.add(SaveModelActionHandler.class);
       binding.add(UndoRedoActionHandler.class);
-      binding.add(DefaultRequestTargetTypeHintsActionHandler.class);
+      binding.add(RequestTargetTypeHintsActionHandler.class);
    }
 
    protected Class<? extends ActionHandlerRegistry> bindActionHandlerRegistry() {

diff --git a/...tRequestTargetTypeHintsActionHandler.java → .../RequestTargetTypeHintsActionHandler.java b/...tRequestTargetTypeHintsActionHandler.java → .../RequestTargetTypeHintsActionHandler.java
@@ -30,7 +30,7 @@
  * should replace this default implementation with their own logic to
  * conditionally accept creation of new edges configured with a Dynamic type.
  */
-public class DefaultRequestTargetTypeHintsActionHandler extends AbstractActionHandler<RequestCheckEdgeTargetAction> {
+public class RequestTargetTypeHintsActionHandler extends AbstractActionHandler<RequestCheckEdgeTargetAction> {
 
    @Inject
    protected DiagramConfiguration diagramConfiguration;