Add ghost elements to tool palette items through trigger actions #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tortmayr
reviewed
Nov 13, 2023
There was a problem hiding this comment.
In general the changes look good to me.
However, I'm wondering whether we should introduce a optionally implementable createTemplate method for node creation tools. This way adopters don't have to override the getTriggerActions method if they want to provide a template.
3 tasks
tortmayr
force-pushed
the
issues/1159
branch
from
54b539b to
dd1557a
Compare
tortmayr
force-pushed
the
issues/1159
branch
from
dd1557a to
3d57690
Compare
tortmayr
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires eclipse-glsp/glsp-client#301
Relates to eclipse-glsp/glsp#1159