[#903]: Make schema optional, allow alternate content type

[ctron]

This change allows to make the schema optional and also allows to
configure the data content type.

Signed-off-by: Jens Reimann [email protected]

[ctron]

Hm, looks like you have a CI check in place that doesn't allow to properly specify the copyright year range.

[thjaeckle]

Hm, looks like you have a CI check in place that doesn't allow to properly specify the copyright year range.

Yes, copyright header for us is only the creation year as this is sufficient according to the Eclipse Foundation Handbook.

[ctron]

Hm, looks like you have a CI check in place that doesn't allow to properly specify the copyright year range.

Yes, copyright header for us is only the creation year as this is sufficient according to the Eclipse Foundation Handbook.

Works for me 👍

[thjaeckle]

Thx @ctron, already looks very promising :)
Added a few requests..

One more thing:
Could you please enhance the services/gateway/starter/src/main/resources/gateway.conf with the cloud-events section (e.g. below public-health { ... }) and the same defaults as in the code, so:

cloud-events {
  empty-schema-allowed = true
  data-types = [
    "application/json"
    "application/vnd.eclipse.ditto+json"
  ]
}

That way Ditto's configuration files act as documentation of what can be configured overall.

[ctron]

I just updated the PR.

[thjaeckle]

The CloudEventsTests would need meaningful tests, but I'm not sure if you want to address all mentioned follow-up tasks of #903 ;)
I would rather delete the current CloudEventsTests class and the one not so useful test to be honest.

[ctron]

The CloudEventsTests would need meaningful tests, but I'm not sure if you want to address all mentioned follow-up tasks of #903 ;)
I would rather delete the current CloudEventsTests class and the one not so useful test to be honest.

I wanted to keep the scope of this PR as is, if possible. And work on the other items in a new PR. Just to keep PRs small.

I tried to explain the idea behind the current state of the unit test above. But as mentioned, I am open to dropping it altogether for this PR.

[thjaeckle]

Thx for the contribution, really appreciated 👍