Add and use typed entity ids #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
* ditto-model * ditto-signals * ditto-protocol-adapter Builders of exceptions had been ignored. Methods that were added to interfaces had been ignored. Movement of WithId Interface has been ignored. Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
…dEntityId.of Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
* Some commands don't actually have an ID. The typed entity id does now provide a "isPlaceholder()" method Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
* Moves the Regex definitions from DefaultNamespacedEntityId into RegexPatterns * renames isPlaceHolder() to isPlaceholder() Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
It does not generate any value. Just more code to understand. Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
* Now we can ommit double implementation of PolicyId in ThingPolicyId Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
* use javax.annotation.concurrent.Immutable instead of jdk.nashorn.internal.ir.annotations.Immutable Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
* to avoid misconceptions regarding placeholders in connectivity terms * also this makes more clear that this ID should not be used Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
thjaeckle
requested changes
Aug 26, 2019
model/base/src/main/java/org/eclipse/ditto/model/base/entity/id/RegexPatterns.java
Outdated
Show resolved
Hide resolved
model/base/src/main/java/org/eclipse/ditto/model/base/entity/id/RegexPatterns.java
Outdated
Show resolved
Hide resolved
model/base/src/main/java/org/eclipse/ditto/model/base/entity/id/package-info.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/eclipse/ditto/model/base/entity/id/NamespacedEntityIdInvalidException.java
Outdated
Show resolved
Hide resolved
...aceholders/src/main/java/org/eclipse/ditto/model/placeholders/EnforcementFactoryFactory.java
Outdated
Show resolved
Hide resolved
...ava/org/eclipse/ditto/services/concierge/actors/cleanup/EventSnapshotCleanupCoordinator.java
Show resolved
Hide resolved
...ava/org/eclipse/ditto/services/concierge/actors/cleanup/EventSnapshotCleanupCoordinator.java
Show resolved
Hide resolved
.../java/org/eclipse/ditto/services/connectivity/mapping/javascript/DefaultIncomingMapping.java
Outdated
Show resolved
Hide resolved
signals/base/src/main/java/org/eclipse/ditto/signals/base/WithIdButActuallyNot.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
as input to resolve the placeholder Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
* This is done to improve readability and to avoid hint from IntelliJ that suggested to remove "unnecessary" optional wrapping (which is wrong) Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
thjaeckle
approved these changes
Aug 26, 2019
Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
Signed-off-by: Klem Yannic (INST/ECS1) <[email protected]>
jokraehe
added a commit
to bosch-io/ditto
that referenced
this pull request
Sep 11, 2019
…-ids WIP: Feature/typed entity ids Signed-off-by: krj1imb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces validated Java representations for entity IDs