Using libffmpegthumbnailer for faster video thumbnail generation #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I modified the generation of video thumbnails to use libffmpegthumbnailer so they are generated more quickly. This requires the installation of the libffmpegthumbnailer-dev library and libffmpegthumbnailer4v5, which is normally installed as a dependency on the previous one.
I only tested it on my Linux machine so I included it only for building the binaries for Linux, when I can I will try it for macOS.
I think we need to check the existence of the libffmpegthumbnailer in the CMakeLists.txt but I'm not sure how to do it.
I hope it is useful and thank you very much for your project.