Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{chem}[gompi/2021b] PCMSolver v1.3.0 w/ Python 3.9.6 #14922

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

sassy-crick
Copy link
Collaborator

@sassy-crick sassy-crick commented Feb 3, 2022

(created using eb --new-pr)

I tried to address this issue a bit better and I could get it to build on an Intel Gold 5118 CPU without any issues. Unfortunately, I don't have access to Zen2 or newer Intel CPUs right now.
My idea was to have the best possible build but avoiding avx and avx2 which seem to cause the problem with one of the test jobs. It is a bit disappointing it has not been addressed by them right now.

@boegel As you raised the issue, would you mind to have a look at that as well?

@lexming
Copy link
Contributor

lexming commented Feb 4, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=14922 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14922 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8039

Test results coming soon (I hope)...

- notification for comment with ID 1030151417 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@lexming
Copy link
Contributor

lexming commented Feb 4, 2022

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node302.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/0514fd6ce7a12b735ebd7fec6b288056 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/961ad82aa34dd6ff0db8beafe3cecdd8 for a full test report.

@lexming
Copy link
Contributor

lexming commented Feb 5, 2022

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on jsfl1.int.jusuf.sebastian.cluster

PR test command 'EB_PR=14922 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14922 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1762

Test results coming soon (I hope)...

- notification for comment with ID 1030483786 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsfc01.int.jusuf.sebastian.cluster - Linux Rocky Linux 8.4, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/5b90070ba33a9e678649ca29ce1002a9 for a full test report.

lexming
lexming previously approved these changes Feb 5, 2022
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests cover Intel Haswell, Intel Skylake and AMD Zen2.

LGTM

@lexming lexming added the update label Feb 5, 2022
@lexming lexming added this to the next release (4.5.3?) milestone Feb 5, 2022
@sassy-crick
Copy link
Collaborator Author

Tests cover Intel Haswell, Intel Skylake and AMD Zen2.

Many thanks for doing this, much appreciated! So that could be a way forward then.
However, I was wondering if it does make more sense to apply that only for the SphericalDiffuse.cpp part of the code as the rest of the code does not seem to be broken. I don't know if that is possible with CMake but I know that GAMESS-US does a similar thing, to have a less aggressive compilation for some parts of the code so the results are correct but leave other parts of it as it is. Just an idea and right now I don't have any hardware to test anything available. 😕

@boegel boegel modified the milestones: 4.5.3, 4.x Feb 9, 2022
@sassy-crick
Copy link
Collaborator Author

@boegel What are we going to do with this rather old but somehow interesting PR? From what I can tell that is the latest release of the software package.

@sassy-crick
Copy link
Collaborator Author

@boegel Ad the broken green-spherical test: seen this PR which looks like an upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants