Changed pytorch & pytorch_vectorized to adapt to Torch1.9 (updates in fft functions) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to adapt to torch 1.9 implementation of fft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Torch1.9 supports complex matrices and thus changed (their ways of interpretation of) input/output to fft functions (in the fft module, see torch doc for more details). Used
torch.view_as_complexandtorch.view_as_realto resolve such issue. Also changed parameters of fft functions according to current torch implementation. Did not change the implementation of the original (spectrogram) functions.Aside: complex matrix method implementation may be changed (to torch native functions) for higher efficiency?