Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All-sky example useful for timing #220

Merged
merged 39 commits into from
Jul 4, 2023
Merged

All-sky example useful for timing #220

merged 39 commits into from
Jul 4, 2023

Conversation

RobertPincus
Copy link
Member

Revises the all-sky example to be useful for timing benchmarks. The atmospheric profile more-or-less follows the profile for RCEMIP at a surface temperature of 300 K. Users specify the number of columns and layers and may choose more than a single iteration. (Array checks are turned off for all but the first iteration). A k-distribution must be specified. Clouds are optional, and occupy 2/3 of columns; aerosols in every other column are optional but require clouds.

A netCDF file is produced; small files of {LW,SW}x{clouds, clouds+aerosols} are used for verification during continuous integration. Timing output is simple, i.e.

ncol   nlay   ngpt  clouds aerosols time_per_col_ms nloops time_total_s time_min_s
     2     32    128       0        0           0.978     24        0.047      0.047

Addresses #128

@RobertPincus
Copy link
Member Author

Also: removes use of NCHOME environment variable, removes (optional) use of GPTL timing library in RFMIP examples.

@Chiil
Copy link
Collaborator

Chiil commented Jul 1, 2023

Design is great, tools works well. Compile and test sequence fails on my workstation because files are not adequately copied to reference in allsky test:

FileNotFoundError: [Errno 2] No such file or directory: '/home/chiel/devel/rte-rrtmgp/rrtmgp-data/examples/all-sky/reference/rrtmgp-allsky-lw-no-aerosols.nc'
make[1]: *** [Makefile:61: check] Error 1
make[1]: Leaving directory '/home/chiel/devel/rte-rrtmgp/examples/all-sky'

I only have a rrtmgp-allsky-no-aerosols.nc

@RobertPincus
Copy link
Member Author

@Chiil Thanks for the feedback. Did you check out branch feature-timing of the data repo as well?

@Chiil
Copy link
Collaborator

Chiil commented Jul 2, 2023 via email

@RobertPincus
Copy link
Member Author

@Chiil If you check out the feature-timing branch of the data repo, do you find all the data there that enables you to run the tests?

Copy link
Collaborator

@Chiil Chiil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RFMIP and all-sky test pass, flexible configurations work. Code can be merged to develop.

@RobertPincus RobertPincus merged commit 36d7969 into develop Jul 4, 2023
39 of 45 checks passed
@RobertPincus RobertPincus deleted the feature-timing branch July 4, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants