Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on jupyter #23

Merged
merged 12 commits into from
Aug 27, 2021
Merged

Work on jupyter #23

merged 12 commits into from
Aug 27, 2021

Conversation

Peter9192
Copy link
Contributor

@Peter9192 Peter9192 commented Aug 26, 2021

Branched off 94df942 (PR #22)

Hello world notebook running marrmot from start to finish:

  • Removes comments about running on Cartesius
  • Change years from 2001 (spinup) and 2002 (experiment) to 1990-1991

Hello worlds notebook running wflow and lisflood:

  • Removes comments about running on Cartesius
  • Now uses new pre-installed parameter set "wflow_merrimack_techpaper". (Note: There is now also "wflow_merrimack_calibrated". Are they the same?)
  • Uses pre-generated forcing stored in /mnt/data/forcing/ and loaded with ewatercycle.forcing.load.
  • Now uses new pre-install parameter set "lisflood_global-masked_01degree" with "settings_lisflood_ERA5.xml". I guess this is the uncalibrated version of the parameterset, but I'm not 100% sure... There are also "settings_lisflood.xml" and "settings_lisflood_ERA5cal.xml", which seem to be exactly the same and not compatible with the parameters that I copied from Cartesius.

Case study 2: replace subbasin in pcrglob with marrmot model

  • Now uses pre-installed pcrglob parameter set
  • Now uses pre-computed forcing file for marrmot Moselle
  • Currently uses several different ini files with slight differences between them. Ideally, it should rather use a/the default one, and modify a few settings after model.setup

Case study 3: replace internal evaporation module in PCRGLobWB

  • Moved/copied PCRGlob global 05 min and 30 min datasets to /mnt/data/parameter-sets, including a couple of custom clone maps and inifiles.
  • A lot of forcing data is also included in global_05min/meteo, but this should probably be moved elsewhere. Keeping it for now.
  • Registered merrimack_05min_era5.ini as default config file in the config user as pcrglobwb_merrimack_05min

Case study 4: calibrate marrmot

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Peter9192 Peter9192 marked this pull request as ready for review August 26, 2021 20:35
Copy link
Contributor

@RolfHut RolfHut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does run on HPC indeed. Merge ok.

@RolfHut RolfHut merged commit 264fe75 into main Aug 27, 2021
@Peter9192 Peter9192 deleted the work-on-jupyter branch August 30, 2021 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants