Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare python publish #27

Merged
merged 13 commits into from
Nov 15, 2024
Merged

Prepare python publish #27

merged 13 commits into from
Nov 15, 2024

Conversation

sverhoeven
Copy link
Member

@sverhoeven sverhoeven commented Nov 12, 2024

TODO

  • Enabled trusted publishing on pypi
  • mypy
  • rich meta data
  • Coverage
  • Publish workflow
  • More tests
    • server some
  • Zenodo integration enabled
  • Cff
  • Code of conduct

…d + dynamic version + fixes return types of py server
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 65.38462% with 18 lines in your changes missing coverage. Please review.

Project coverage is 55.41%. Comparing base (ea6d377) to head (956cc6d).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (ea6d377) and HEAD (956cc6d). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (ea6d377) HEAD (956cc6d)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #27       +/-   ##
===========================================
- Coverage   89.19%   55.41%   -33.78%     
===========================================
  Files          44        7       -37     
  Lines        2147      406     -1741     
  Branches        0        8        +8     
===========================================
- Hits         1915      225     -1690     
+ Misses        232      179       -53     
- Partials        0        2        +2     
Components Coverage Δ
Python 55.41% <65.38%> (∅)
Julia ∅ <ø> (∅)
R ∅ <ø> (∅)

@sverhoeven sverhoeven marked this pull request as ready for review November 12, 2024 15:58
Copy link
Member

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I did not run the code, but mostly saw some small issues.

Once the issues are resolved feel free to merge.

python/README.md Show resolved Hide resolved
python/pyproject.toml Outdated Show resolved Hide resolved
python/src/remotebmi/client/client.py Show resolved Hide resolved
python/src/remotebmi/client/client.py Outdated Show resolved Hide resolved
python/src/remotebmi/server/api.py Outdated Show resolved Hide resolved
python/src/remotebmi/client/client.py Show resolved Hide resolved
python/tests/test_server.py Show resolved Hide resolved
.github/workflows/python.yml Show resolved Hide resolved
.github/workflows/python.yml Show resolved Hide resolved
@BSchilperoort
Copy link
Member

Tests (except code coverage) is green now. Comments are resolved or moved to an issue.

@BSchilperoort BSchilperoort merged commit d6a7125 into main Nov 15, 2024
13 of 15 checks passed
@BSchilperoort BSchilperoort deleted the python-publish branch November 15, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants