-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare python publish #27
Conversation
…d + dynamic version + fixes return types of py server
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
===========================================
- Coverage 89.19% 55.41% -33.78%
===========================================
Files 44 7 -37
Lines 2147 406 -1741
Branches 0 8 +8
===========================================
- Hits 1915 225 -1690
+ Misses 232 179 -53
- Partials 0 2 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I did not run the code, but mostly saw some small issues.
Once the issues are resolved feel free to merge.
Co-authored-by: Bart Schilperoort <[email protected]>
Tests (except code coverage) is green now. Comments are resolved or moved to an issue. |
TODO