Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generated openapi julia client #16

Merged
merged 9 commits into from
Oct 24, 2024
Merged

Conversation

sverhoeven
Copy link
Member

@sverhoeven sverhoeven commented Oct 15, 2024

TODO

  • get working
  • add happy tests
  • add wrong usage tests
  • get rid of EOFError from server logs when running tests

@sverhoeven sverhoeven mentioned this pull request Oct 15, 2024
8 tasks
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 87.60563% with 220 lines in your changes missing coverage. Please review.

Project coverage is 87.61%. Comparing base (61b6052) to head (fd95287).
Report is 10 commits behind head on julia-tests.

Files with missing lines Patch % Lines
...emoteBMI.jl/src/client/apis/api_UnstructuredApi.jl 74.41% 22 Missing ⚠️
...I.jl/src/client/apis/api_VariableInformationApi.jl 76.25% 19 Missing ⚠️
...teBMI.jl/src/server/models/model_ProblemDetails.jl 0.00% 18 Missing ⚠️
...moteBMI.jl/src/client/apis/api_ExchangeItemsApi.jl 71.92% 16 Missing ⚠️
...teBMI.jl/src/client/apis/api_TimeInformationApi.jl 71.92% 16 Missing ⚠️
RemoteBMI.jl/src/client/apis/api_IRFApi.jl 71.73% 13 Missing ⚠️
...teBMI.jl/src/client/apis/api_GridInformationApi.jl 73.68% 10 Missing ⚠️
RemoteBMI.jl/src/client/apis/api_NURCApi.jl 73.68% 10 Missing ⚠️
...MI.jl/src/client/apis/api_UniformRectilinearApi.jl 73.68% 10 Missing ⚠️
RemoteBMI.jl/src/Server.jl 94.19% 9 Missing ⚠️
... and 19 more
Additional details and impacted files
@@               Coverage Diff                @@
##           julia-tests      #16       +/-   ##
================================================
+ Coverage        45.87%   87.61%   +41.73%     
================================================
  Files               24       42       +18     
  Lines              800     1776      +976     
================================================
+ Hits               367     1556     +1189     
+ Misses             433      220      -213     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sverhoeven sverhoeven marked this pull request as ready for review October 24, 2024 10:53
@sverhoeven sverhoeven merged commit ee21e68 into julia-tests Oct 24, 2024
1 check passed
@sverhoeven sverhoeven deleted the julia-openapi-client branch October 24, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant