R server #10
Open
R server #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged eWaterCycle/bmi-r#3 |
|
Cool, I'm looking forward to trying it out! 🚀 |
|
|
||
| ``` r | ||
| # install.packages("pak") | ||
| pak::pak("github::eWaterCycle/remotebmi/R/remotebmi") |
There was a problem hiding this comment.
This command does not work,
> pak::pak("github::eWaterCycle/remotebmi/R/remotebmi")
! Using bundled GitHub PAT. Please add your own PAT using `gitcreds::gitcreds_set()`.
Error:
! error in pak subprocess
Caused by error:
! Could not solve package dependencies:
* github::eWaterCycle/remotebmi/R/remotebmi: ! pkgdepends resolution error for
github::eWaterCycle/remotebmi/R/remotebmi.
Caused by error:
! Can't find R package in GitHub repo eWaterCycle/remotebmi in directory 'R/remotebmi'
Is that because of this:?
rename package from R/remotebmi to /remotebmir
There was a problem hiding this comment.
Hmm, the path is according to https://pak.r-lib.org/reference/pak_package_sources.html#github-packages-github-
I was using
cd R/remotebmi
R
devtools::load_all()
# and/or
devtools::install_local()
There was a problem hiding this comment.
Ah that uses main branch, try pak::pak("github::eWaterCycle/remotebmi/R/remotebmi#10")
There was a problem hiding this comment.
I git cloned the repo and installed it from a local path. That worked fine
| ## basic example code | ||
|
|
||
| pak::pak("github::ClaudiaBrauer/WALRUS") | ||
| pak::pak("github::eWaterCycle/bmi-r") |
There was a problem hiding this comment.
I get stuck on building the stringi package. install.package("stringi") fails to build, and R binaries are only available for Windows and MacOS, not linux 🙄
There was a problem hiding this comment.
Managed to finally build it with install.packages("stringi", configure.args="--disable-pkg-config")
| array([0.0044]) | ||
| client.get_var_nbytes('Q') | ||
| 'mm/h' | ||
| # TODO get_var_nbytes should return int not str |
There was a problem hiding this comment.
Interesting error! Seems like a mismapping of a function (get_var_units vs. get_var_nbytes)
There was a problem hiding this comment.
yep, seems I fixed it in https://github.com/eWaterCycle/grpc4bmi-examples/pull/10/files, but never completed it.
|
Something still seems to be going wrong. I can do the first update, but after the second .update() I can't use get_value anymore: The running R server shows no errors |
What does R server say and what does curl do |
Before the first update it returns nothing. After one update it returns So that looks OK. Running the curl command and then using get_value also works fine 😕 .
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO