Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install jupyterlab_code_formatter Jupyter lab extension #44

Merged
merged 8 commits into from
Jul 8, 2020
Merged

Install jupyterlab_code_formatter Jupyter lab extension #44

merged 8 commits into from
Jul 8, 2020

Conversation

sverhoeven
Copy link
Member

@sverhoeven sverhoeven commented Mar 26, 2020 •
edited
Loading

Fixes #37

@sverhoeven
Copy link
Member Author

By default black is used as formatter.

@sverhoeven sverhoeven changed the title Install jupyterlab_code_formatter and it's supported Python code form… Install jupyterlab_code_formatter Jupyter lab extension Mar 26, 2020
@sverhoeven
Copy link
Member Author

sverhoeven commented Mar 26, 2020 •
edited
Loading

The latest @ryantam626/[email protected] conflicts with the installed JupyterLab.

I tried all the releases of the formatter and they all conflict.

So to install I need to upgrade the installed JupyterLab and all the other installed extensions and their dependencies. This also includes my jupyterlab_thredds extension which will need to be updated.

@sverhoeven sverhoeven marked this pull request as ready for review July 7, 2020 08:26
@sverhoeven
Copy link
Member Author

Tested on vagrant machine.

After PR merge need deployment to jupyter.ewatercycle.org
machine.

Peter9192
Peter9192 approved these changes Jul 8, 2020
View reviewed changes
Copy link
Collaborator

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Vagrant. I just wonder if we can include https://github.com/mlshapiro/jupyterlab-flake8 as well.

@sverhoeven
Copy link
Member Author

good idea will try to install linter as well

@sverhoeven
Copy link
Member Author

Tried to install jupyterlab-flake8 , but did not work on Vagrant due to Error during WebSocket handshake: Unexpected response code: 302. Created #57 to solve later.

@sverhoeven sverhoeven merged commit f04e6c6 into master Jul 8, 2020
@sverhoeven sverhoeven deleted the code-formatter branch July 8, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peter9192 Peter9192 Peter9192 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add notebook extensions for code formatting
2 participants
@sverhoeven @Peter9192