Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conda-lock #165

Merged
merged 32 commits into from
Sep 5, 2024
Merged

Use conda-lock #165

merged 32 commits into from
Sep 5, 2024

Conversation

sverhoeven
Copy link
Member

@sverhoeven sverhoeven commented Aug 28, 2024

Fixes #164

Also

  • upgrades vagrant base box to ubuntu 22.04 which is same as SRC catalog item

To test

  1. Spin up a machine either in SRC or with vagrant
  2. Check that landing page looks ok and links work
  3. Login to JupyterHub
  4. Run https://github.com/eWaterCycle/ewatercycle/blob/main/README.md#usage example

@sverhoeven
Copy link
Member Author

2 conda-lock files (one from ewatercycle repo and one for jupyter) can not be be merged. So we first install the conda-lock from ewatercycle repo and then use a conda env file with pinned versions to install jupyter.

@sverhoeven
Copy link
Member Author

To do second vagrant provision I had to fix vagrant see https://github.com/hashicorp/vagrant/pull/13493

@sverhoeven
Copy link
Member Author

roles/ewatercycle/templates/environment.yml.j2 now has direct dependencies pinned.

This should be more reproducible, but you will miss security updates and deps of deps can still break things.

@BSchilperoort
Copy link
Member

BSchilperoort commented Sep 4, 2024

2 conda-lock files (one from ewatercycle repo and one for jupyter) can not be be merged. So we first install the conda-lock from ewatercycle repo and then use a conda env file with pinned versions to install jupyter.

I guess the alternative would be to built a completely new conda-lock file from scratch? Is that possible/viable/desirable?

@sverhoeven sverhoeven marked this pull request as ready for review September 5, 2024 12:37
Copy link
Member

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things work now 👍

@sverhoeven sverhoeven merged commit 61659a4 into main Sep 5, 2024
1 check passed
@sverhoeven sverhoeven deleted the conda-lock branch September 5, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use conda lock
2 participants