Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint extension #57

Open
sverhoeven opened this issue Jul 8, 2020 · 2 comments
Open

Lint extension #57

sverhoeven opened this issue Jul 8, 2020 · 2 comments

Comments

@sverhoeven
Copy link
Member

The code formatter (#37) can not fix all lint problems. It would be nice to see lint problems in the notebook. There is a JupyterLab extension https://github.com/mlshapiro/jupyterlab-flake8 that could do this.
This was referenced Jul 8, 2020
Merged
Closed
@sverhoeven
Copy link
Member Author

Trying alternative https://github.com/krassowski/jupyterlab-lsp

sverhoeven added a commit that referenced this issue Jul 22, 2020
@sverhoeven
Added jupyterlab-lsp
58ae4c1 
Fixes #57
@sverhoeven
Copy link
Member Author

Seems https://github.com/krassowski/jupyterlab-lsp is now quicker, we could give it another try.

We should take care it does not interfere with other installed linters/formatters like jupyterlab_code_formatter like.

Also it should be fast enough for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Code linter eWaterCycle/infra
1 participant
@sverhoeven