Add get_shape_area() and plot_shape() methods to DefaultForcing

[RolfHut]

first commit added get_shape_area (needs testing)

[codecov]

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.29%. Comparing base (ee28ec6) to head (86314e2).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/ewatercycle/esmvaltool/run.py	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
+ Coverage   78.83%   79.29%   +0.45%     
==========================================
  Files          28       28              
  Lines        1810     1850      +40     
  Branches      218      155      -63     
==========================================
+ Hits         1427     1467      +40     
  Misses        325      325              
  Partials       58       58              

Files with missing lines	Coverage Δ
src/ewatercycle/base/forcing.py	84.33% <100.00%> (+4.97%)	⬆️
src/ewatercycle/esmvaltool/run.py	55.00% <0.00%> (ø)

[RolfHut]

tested and works, but check fails, I could use some tips on the checks that are being run and the best practices we adhere to in coding style

[BSchilperoort]

Thanks for picking this up! There are instructions in the CONTRIBUTING.md document.

I think the instructions are missing that pip3 install -e . should actually be pip3 install -e .[dev] (so the dev dependencies are installed as well).

To run the pre-commit hook manually (on all files, not associated with a commit), you can do pre-commit run --all. This should fix the formatting issues.

The codecov check is failing because you've added code that is not tested. If you would add tests for the two functions this should be fixed. For the shape area you can easily check if the output is numerically correct. Testing the plotting code is more difficult, maybe we only check if it ran without errors.

[BSchilperoort]

These suggestions should fix most issues.

[BSchilperoort]

I've fixed the linting/formatting issues and added tests for the new methods. Everything's good now ✔️