Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the newest OPeNDAP version of Caravan, patch data issues. #458

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BSchilperoort
Copy link
Member

@BSchilperoort BSchilperoort commented Sep 17, 2024

This PR fixes some issues in the already hosted dataset:

  • homogenizes variable names
  • converts all units
  • massages the data into the right format to have the data the users needed

It also adds a new kwarg to download the shapefiles, by default downloading the shapefile is now skipped.

@BSchilperoort
Copy link
Member Author

@RolfHut could you try this branch to see if it fits with what you started in #433

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 55.35714% with 25 lines in your changes missing coverage. Please review.

Project coverage is 78.10%. Comparing base (2f2d7c0) to head (9edf8dd).

Files with missing lines Patch % Lines
src/ewatercycle/_forcings/caravan.py 53.70% 17 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   78.83%   78.10%   -0.74%     
==========================================
  Files          28       29       +1     
  Lines        1810     1850      +40     
  Branches      218      224       +6     
==========================================
+ Hits         1427     1445      +18     
- Misses        325      342      +17     
- Partials       58       63       +5     
Files with missing lines Coverage Δ
src/ewatercycle/_forcings/_caravan_reference.py 100.00% <100.00%> (ø)
src/ewatercycle/_forcings/caravan.py 71.42% <53.70%> (-11.73%) ⬇️

@BSchilperoort BSchilperoort mentioned this pull request Sep 17, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant