Add .devcontainer + .vscode/extensions.json #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past the DefaultForcing.generate() and load() methods had docstrings that rendered the model_specific_options of some models. Now those models are in their own repos, so no longer need it here.
As recommonmark is deprecated myst-nb has myst-parser as deps, so any *.md will also be processed by myst
autodoc2 does not handle google style docstrings so we switch back to the original autoapi.
TODO * [ ] edit python file * [ ] ewatercycle env activated * [ ] navigation * [ ] ruff * [ ] mypy * [ ] in terminal * [ ] ewatercycle env activated * [ ] ruff * [ ] mypy * [ ] pytest Refs #441
Use removeEnv to set path + set envs in dockerfile
sverhoeven
changed the title
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #452 +/- ##
=======================================
Coverage 78.93% 78.93%
=======================================
Files 28 28
Lines 1804 1804
Branches 216 216
=======================================
Hits 1424 1424
Misses 323 323
Partials 57 57 |
BSchilperoort
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
First I used the link on the badge, but that didn't work correctly yet (as it refers to the main branch).
Manually cloning the repo and checking out this branch worked:
- dev container installed successfully
- specified VS Code extensions were installed automatically
pytestran sucessfully inside the dev containercd docs; make htmlgenerated the docs no problem
Nice work! 😄
Can you add a short mention of this VS Code dev container setup in the CONTRIBUTING.md file? That would allow others to find it more easily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Refs #441